Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

member-ordering: Support categories #2041

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

andy-hanson
Copy link
Contributor

PR checklist

What changes did you make?

Changed member-ordering to allow to use categories rather than just a single option.
This also lets us get rid of the "old" options as they can be described in terms of new presets using categories.

Copy link
Contributor

@nchen63 nchen63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @andy-hanson

@nchen63 nchen63 merged commit 18e7604 into palantir:master Jan 19, 2017
@nchen63
Copy link
Contributor

nchen63 commented Jan 25, 2017

@andy-hanson I get a whole bunch of errors when linting tslint src files using existing tslint.json on develop

(member-ordering) src/rules/whitespaceRule.ts[217, 5]: Declaration of public member not allowed after declaration of private member. Instead, this should come at the beginning of the class/inter
face.
(member-ordering) src/runner.ts[110, 5]: Declaration of public member not allowed after declaration of private member. Instead, this should come at the beginning of the class/interface.
(member-ordering) src/runner.ts[112, 5]: Declaration of public member not allowed after declaration of private member. Instead, this should come at the beginning of the class/interface.

nchen63 pushed a commit that referenced this pull request Jan 25, 2017
nchen63 added a commit that referenced this pull request Jan 25, 2017
* Revert "member-ordering: Support categories (#2041)"

This reverts commit 18e7604.

* Revert "Rewrite member-ordering rule (#1957)"

This reverts commit e6ca414.
@andy-hanson andy-hanson deleted the member_ordering_categories branch January 26, 2017 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants