Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Ignore tslint:disable comments in comment-format/check-uppercase rule #1417

Closed
glen-84 opened this issue Jul 19, 2016 · 2 comments
Closed

Ignore tslint:disable comments in comment-format/check-uppercase rule #1417

glen-84 opened this issue Jul 19, 2016 · 2 comments
Labels
P2 Resolution: Fixed Type: Enhancement
Milestone
TSLint v3.15

Comments

@glen-84
Copy link
Contributor

glen-84 commented Jul 19, 2016

Bug Report

  • TSLint version: 3.10.2
  • TypeScript version: 1.8.10
  • Running TSLint via: VS Code

TypeScript code being linted

// tslint:disable-next-line:no-unused-expression

with tslint.json configuration:

(not relevant)

Actual behavior

comment must start with uppercase letter

Expected behavior

Not expected, but it would be nice if this was ignored as an exception to the comment rule.

A multi-line comment can be used instead, but it's not ideal.
@adidahiya
Copy link
Contributor

agreed, this exception would be nice to have

@adrianpacala
Copy link
Contributor

I've just run into this issue, so 👍.

IllusionMH added a commit to IllusionMH/tslint that referenced this issue Aug 10, 2016
@IllusionMH
Update comment-format/check-uppercase to ignore rule flags (fixes pal…
16f79d9 
…antir#1417)
IllusionMH added a commit to IllusionMH/tslint that referenced this issue Aug 10, 2016
@IllusionMH
Update comment-format/check-uppercase to ignore rule flags (fixes pal…
106d12e 
…antir#1417)
@IllusionMH IllusionMH mentioned this issue Aug 10, 2016
Merged
adidahiya pushed a commit that referenced this issue Aug 11, 2016
@IllusionMH @adidahiya
Update comment-format/check-uppercase to ignore rule flags (#1473)
83bdd34 
Fixes #1417
@adidahiya adidahiya added this to the TSLint v3.15 milestone Aug 11, 2016
soniro pushed a commit to soniro/tslint that referenced this issue Aug 31, 2016
@IllusionMH
Update comment-format/check-uppercase to ignore rule flags (palantir#…
d2ce671 
…1473)

Fixes palantir#1417
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 Resolution: Fixed Type: Enhancement
Projects
None yet
Milestone
TSLint v3.15
Development

No branches or pull requests
3 participants
@adrianpacala @glen-84 @adidahiya