no-unnecessary-qualifier: make it work with typescript@next (#3052)

Seems like typescript used to return the same symbol. That was changed in [email protected] and caused the tests to fail. This fix now compares the declarations of the symbols instead of checking the symbols for equality. Fixes: #3047 [no-log]
palantir · Jul 20, 2017 · f9e162f · f9e162f
1 parent c32bdc4
commit f9e162f
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 4 deletions.
diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts
@@ -98,7 +98,7 @@ function walk(ctx: Lint.WalkContext<void>, checker: ts.TypeChecker): void {
 
         // If the symbol in scope is different, the qualifier is necessary.
         const fromScope = getSymbolInScope(qualifier, accessedSymbol.flags, name.text);
-        return fromScope === undefined || fromScope === accessedSymbol;
+        return fromScope === undefined || Lint.Utils.arraysAreEqual(fromScope.declarations, accessedSymbol.declarations, (a, b) => a === b);
     }
 
     function getSymbolInScope(node: ts.Node, flags: ts.SymbolFlags, name: string): ts.Symbol | undefined {

diff --git a/test/rules/no-unnecessary-qualifier/arguments.ts.lint b/test/rules/no-unnecessary-qualifier/arguments.ts.lint
@@ -1,4 +1,3 @@
-[typescript]: < 2.5.0
 namespace N {
     export type T = number;
     export const x: N.T = 0;

diff --git a/test/rules/no-unnecessary-qualifier/test-global.ts.lint b/test/rules/no-unnecessary-qualifier/test-global.ts.lint
@@ -1,4 +1,3 @@
-[typescript]: < 2.5.0
 namespace N {
     export type T = number;
     export const x: N.T = 0;

diff --git a/test/rules/no-unnecessary-qualifier/test.ts.lint b/test/rules/no-unnecessary-qualifier/test.ts.lint
@@ -1,4 +1,3 @@
-[typescript]: < 2.5.0
 namespace N {
     export type T = number;
     export const x: N.T = 0;