noInferrableTypes: check property declarations. (#2081)

palantir · Jan 21, 2017 · 48b0c59 · 48b0c59
1 parent c2c0054
commit 48b0c59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/rules/noInferrableTypesRule.ts b/src/rules/noInferrableTypesRule.ts
@@ -69,7 +69,12 @@ class NoInferrableTypesWalker extends Lint.RuleWalker {
         super.visitParameterDeclaration(node);
     }
 
-    private checkDeclaration(node: ts.ParameterDeclaration | ts.VariableDeclaration) {
+    public visitPropertyDeclaration(node: ts.PropertyDeclaration) {
+        this.checkDeclaration(node);
+        super.visitPropertyDeclaration(node);
+    }
+
+    private checkDeclaration(node: ts.ParameterDeclaration | ts.VariableDeclaration | ts.PropertyDeclaration) {
         if (node.type != null && node.initializer != null) {
             let failure: string | null = null;
 

diff --git a/test/rules/no-inferrable-types/default/test.ts.lint b/test/rules/no-inferrable-types/default/test.ts.lint
@@ -5,6 +5,10 @@ let y: boolean = false;
        ~~~~~~~          [boolean]
 let z: string = "foo";
        ~~~~~~           [string]
+class C {
+    x: number = 1;
+       ~~~~~~           [number]
+}
 
 // errors, types are inferrable
 function foo (a: number = 5, b: boolean = true, c: string = "bah") { }