restrict increment-decrement fixer while fixing the postfix unary exp…

…ressions (#4415)
palantir · Dec 29, 2018 · 47a7218 · 47a7218
1 parent e1ddce0
commit 47a7218
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/src/rules/incrementDecrementRule.ts b/src/rules/incrementDecrementRule.ts
@@ -80,7 +80,14 @@ function walk(context: Lint.WalkContext<Options>) {
 
     function complainOnNode(node: ts.PostfixUnaryExpression | ts.PrefixUnaryExpression) {
         const newOperatorText = node.operator === ts.SyntaxKind.PlusPlusToken ? "+= 1" : "-= 1";
-        const replacement = createReplacement(node, newOperatorText);
+        let replacement: Lint.Replacement | undefined;
+
+        if (
+            tsutils.isPrefixUnaryExpression(node) ||
+            node.parent.kind === ts.SyntaxKind.ExpressionStatement
+        ) {
+            replacement = createReplacement(node, newOperatorText);
+        }
 
         const failure = Rule.FAILURE_STRING_FACTORY(newOperatorText);
 

diff --git a/test/rules/increment-decrement/default/test.ts.fix b/test/rules/increment-decrement/default/test.ts.fix
@@ -14,13 +14,16 @@ x - 1;
 1 - x;
 
 x + (x += 1);
-x + (x += 1);
+x + x++;
 
 x - (x -= 1);
-x - (x -= 1);
+x - x--;
 
 (x += 1) + x;
-(x += 1) + x;
+x++ + x;
 
 (x -= 1) - x;
-(x -= 1) - x;
+x-- - x;
+
+expect(x++)
+expect(x += 1)
diff --git a/test/rules/increment-decrement/default/test.ts.lint b/test/rules/increment-decrement/default/test.ts.lint
@@ -38,3 +38,8 @@ x-- - x;
 ~~~       [minus]
 [plus]:       Use an explicit += 1 operator.
 [minus]:       Use an explicit -= 1 operator.
+
+expect(x++)
+       ~~~       [plus]
+expect(++x)
+       ~~~       [plus]