Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target JDK 17 bytecode & APIs #1958

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Target JDK 17 bytecode & APIs #1958

merged 4 commits into from
Oct 18, 2024

Conversation

schlosna
Copy link
Contributor

@schlosna schlosna commented Jun 6, 2024

Before this PR

#1956 is failing due to delegate-processors:1.2.0 bump targeting JDK 17 bytecode via palantir/delegate-processors#105

After this PR

==COMMIT_MSG==
Target JDK 17 bytecode & APIs
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Jun 6, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Target JDK 17 bytecode & APIs

Check the box to generate changelog(s)

  • Generate changelog entry

pkoenig10
pkoenig10 previously approved these changes Jun 6, 2024
@schlosna schlosna requested a review from CRogers June 6, 2024 12:37
@schlosna
Copy link
Contributor Author

schlosna commented Jun 6, 2024

Holding off merging pending confirmation of any JDK 11 stragglers

build.gradle Outdated Show resolved Hide resolved
.java-version Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary with #2013

@bmarcaur bmarcaur requested a review from carterkozak October 18, 2024 03:55
bmarcaur
bmarcaur previously approved these changes Oct 18, 2024
@policy-bot policy-bot bot dismissed bmarcaur’s stale review October 18, 2024 15:22

Invalidated by push of 8f9825a

@schlosna
Copy link
Contributor Author

unleash the hounds

@bulldozer-bot bulldozer-bot bot merged commit 6bf5c16 into develop Oct 18, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the davids/jdk17 branch October 18, 2024 16:26
@autorelease3
Copy link

autorelease3 bot commented Oct 18, 2024

Released 0.95.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants