MetricName TagMap supports replacement of existing entries #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
schlosna
approved these changes
Aug 1, 2022
tritium-registry/src/main/java/com/palantir/tritium/metrics/registry/TagMap.java
Outdated
Show resolved
Hide resolved
tritium-registry/src/test/java/com/palantir/tritium/metrics/registry/TagMapTest.java
Outdated
Show resolved
Hide resolved
…gistry/TagMap.java
…gistry/TagMapTest.java Co-authored-by: David Schlosnagle <[email protected]>
|
Released 0.50.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I've been thinking about adding additional data to our metrics describing the jvm runtime.
Some potential approaches would introduce risk that existing tags are repeated, although I suspect we'd use an approach including validation within metric-schema. In the event that there's some risk of key overriding, we'd want tritium to support it gracefully long before anything else relied on the functionality.
Before this PR
After this PR
==COMMIT_MSG==
MetricName TagMap supports replacement of existing entries
==COMMIT_MSG==
Possible downsides?
Slightly more code in
withEntrycould be harder for the jvm to optimize