Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused @MetricGroup annotation helpers #1478

Merged
merged 2 commits into from
May 5, 2022

Conversation

schlosna
Copy link
Contributor

@schlosna schlosna commented May 5, 2022

Before this PR

Noticed an unnecessary exception due to the unused @MetricGroup and AnnotationHelper code, so ripping this dead code out.

  at java.lang.Throwable.fillInStackTrace([email protected]/Native Method)
  at java.lang.Throwable.fillInStackTrace([email protected]/Throwable.java:799)
  - locked <0x00007f3174f61730> (a java.lang.NoSuchMethodException)
  at java.lang.Throwable.<init>([email protected]/Throwable.java:272)
  at java.lang.Exception.<init>([email protected]/Exception.java:67)
  at java.lang.ReflectiveOperationException.<init>([email protected]/ReflectiveOperationException.java:57)
  at java.lang.NoSuchMethodException.<init>([email protected]/NoSuchMethodException.java:51)
  at java.lang.Class.getMethod([email protected]/Class.java:2201)
  at com.palantir.tritium.event.metrics.annotations.AnnotationHelper.getMethodAnnotation(AnnotationHelper.java:73)
  at com.palantir.tritium.event.metrics.annotations.AnnotationHelper.getMethodAnnotation(AnnotationHelper.java:83)
  at com.palantir.tritium.event.metrics.MetricsInvocationEventHandler.createMethodGroupMapping(MetricsInvocationEventHandler.java:90)
  at com.palantir.tritium.event.metrics.MetricsInvocationEventHandler.<init>(MetricsInvocationEventHandler.java:72)
  at com.palantir.tritium.proxy.Instrumentation$Builder.withMetrics(Instrumentation.java:136)
  at com.palantir.tritium.proxy.Instrumentation$Builder.withMetrics(Instrumentation.java:141)
  at com.palantir.tritium.Tritium.instrument(Tritium.java:44)

After this PR

==COMMIT_MSG==
Remove unused @MetricGroup annotation helpers

This was never used and the code for it has rotted, so time to purge.
The @MetricGroup annotation still exists to prevent any immediate ABI
breaks, but have been deprecated and will be removed in future.
==COMMIT_MSG==

Possible downsides?

This was never used and the code for it has rotted, so time to purge.
The @MetricGroup annotation still exists to prevent any immediate ABI
breaks, but have been deprecated and will be removed in future.
@changelog-app
Copy link

changelog-app bot commented May 5, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove unused @MetricGroup annotation helpers

This was never used and the code for it has rotted, so time to purge.
The @MetricGroup annotation still exists to prevent any immediate ABI
breaks, but have been deprecated and will be removed in future.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 4edebab into develop May 5, 2022
@bulldozer-bot bulldozer-bot bot deleted the ds/remove-annotation-helper branch May 5, 2022 11:59
@svc-autorelease
Copy link
Collaborator

Released 0.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants