-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shuffle biased task scheduling #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (pushed changes rather than comments), but preferably should get another set of eyes given the scope of said changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the import nit - otherwise lgtm
Another optimization to the work begun in #427
When scheduling tasks, bias towards putting them on executors which hold active shuffle data, so we are more likely to be able to remove executors that don't.
This code is taken from the original PR and re-introduced here as a separate PR.
Still needs to be live-tested.