Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle biased task scheduling #447

Merged
merged 6 commits into from
Nov 28, 2018
Merged

Conversation

rynorris
Copy link

Another optimization to the work begun in #427

When scheduling tasks, bias towards putting them on executors which hold active shuffle data, so we are more likely to be able to remove executors that don't.

This code is taken from the original PR and re-introduced here as a separate PR.

Still needs to be live-tested.

@rynorris rynorris changed the title Re-introduce shuffle bias task scheduling code Shuffle biased task scheduling Nov 27, 2018
Copy link

@lwwmanning lwwmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (pushed changes rather than comments), but preferably should get another set of eyes given the scope of said changes

@lwwmanning lwwmanning requested a review from mccheah November 27, 2018 15:58
Copy link

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the import nit - otherwise lgtm

@robert3005 robert3005 merged commit 4dc83b4 into master Nov 28, 2018
@robert3005 robert3005 deleted the rn/shuffle-biased-scheduling branch November 28, 2018 20:45
robert3005 pushed a commit that referenced this pull request Jan 6, 2019
lwwmanning pushed a commit that referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants