Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization to #427
In the original PR we only track whether a shuffle dependency is active at the job-level, meaning we cannot scale up and down executors during a long job.
This PR extends the functionality by tracking the dependencies between stages and shuffles so we can mark the shuffle blocks as inactive earlier.
Unit tests included, and also tested on a local k8s cluster.
See toy example:
In this screenshot, stage 5.0 repartitions to 4 partitions, stage 6.0 to 2 partitions, and stage 7.0 to 1 partition. The exact query used was:
You can see that once stage 6.0 is done, executors 6 and 8 are removed since their shuffle data is no longer needed. However executors 5 and 7 are both kept around during the last stage even though there's only one task, because they both hold shuffle data necessary for the final repartition to run.