Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Foundry Product Type #1703

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Add Foundry Product Type #1703

merged 3 commits into from
Sep 26, 2024

Conversation

jakobjuelich
Copy link
Contributor

@jakobjuelich jakobjuelich commented Sep 24, 2024

Before this PR

The createManifest task could only be used to create services, daemons, helm charts, or assets.

After this PR

==COMMIT_MSG==
Add Foundry Product Type

Foundry Products were recently introduced as a concept in Apollo. With this PR, we can create products with this product type using the sls packaging plugin.
==COMMIT_MSG==

Possible downsides?

This PR is analogous to how helm-charts were added here: #1645

@changelog-app
Copy link

changelog-app bot commented Sep 24, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Added Foundry Product Type

Check the box to generate changelog(s)

  • Generate changelog entry

TheKeveloper
TheKeveloper previously approved these changes Sep 24, 2024
@policy-bot policy-bot bot dismissed TheKeveloper’s stale review September 24, 2024 14:30

Invalidated by push of d2c73f9

Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - there is already corresponding support for foundry-product.v1 in apollo-catalog.

Copy link

@Ricky-N Ricky-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jakobjuelich jakobjuelich merged commit d4e3538 into develop Sep 26, 2024
5 checks passed
@jakobjuelich jakobjuelich deleted the jj/foundry-product branch September 26, 2024 15:10
@autorelease3
Copy link

autorelease3 bot commented Sep 26, 2024

Released 7.67.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants