Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sls-packaging sets the individual-addressability extension #1643

Merged
merged 3 commits into from
May 9, 2024

Conversation

carterkozak
Copy link
Contributor

We enforce this everywhere in code, however we need to make sure stragglers are picked up to avoid infrastructure failures. We could assume the manifest default is true, however that is risky for older product. This way new releases pick up the new value if it's not already specified.

==COMMIT_MSG==
sls-packaging sets the individual-addressability extension default value to true when not otherwise specified
==COMMIT_MSG==

Possible downsides?

Ideally we excavate this into buildscripts first, which we've done in 99.9% of projects at this point. This acts as a backstop for one-off projects, assuming they take sls-packaging upgrades. This will apply to other languages as well as Java.

We enforce this everywhere in code, however we need to make sure
stragglers are picked up to avoid infrastructure failures. We
could assume the manifest default is true, however that is risky
for older product. This way new releases pick up the new value
if it's not already specified.
@changelog-app
Copy link

changelog-app bot commented May 9, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

sls-packaging sets the individual-addressability extension default value to true when not otherwise specified

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 9c418a1 into develop May 9, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/individual-addressability branch May 9, 2024 15:57
@svc-autorelease
Copy link
Collaborator

Released 7.54.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants