-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 'object constancy' on data refresh by supporting a key function in Dataset #2801
Conversation
Refactor mouse dispatcher tests - Pass 1
…NoConstancy key is used with the Dataset, this animation becomes the default behaviour
@softwords |
Add clipPath to selectionBoxLayer
@bluong; >>drastic whitespace changes |
…NoConstancy key is used with the Dataset, this animation becomes the default behaviour
@softwords Feel free to reach out if you need any help in development! |
@bluong thanks for the encouragement! I'll have another attempt to get this one ready, and get comfortable with the workflow. |
see issue #2512
This pull request
-- NoConstancy - which will return a new value each time it is called, therefire ensuring that there is never object constancy; that is, all elements in the selection are removed and recreated
-- ByIndex - returns the index of the datum n the array, which is the default behaviour of d3 anyway
This also resolves issue Animator behavior can be altered by calling datasets.data() ??? #2707.