NON-NLS more difficult example #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah dang :/ |
| @@ -17,4 +17,6 @@ class MultilineStringConstant { | |||
| "field_3," + | |||
| "field_4"; | |||
|
|
|||
| private static final String SINGLE_LINE_NON_NLS = "field_0," + "field_1," + "field_2," + "field_3," + "field_4"; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ | |||
There was a problem hiding this comment.
Is this for real??
I'd like to have a look at a comprehensive set of rules showing all the ways that these comments work.
- do we need an extra
//for each$NON-NLSinstance? - does each comment map to a string literal, or could they be mapped to string constants / variables as well?
- do we only need to handle string concatenations or other AST shapes too?
There was a problem hiding this comment.
- Yep, that's correct
- Each comment is associated with a string literal, these are string constants in source
- This applies beyond concatenation, for example
return getFoo("a", "b") //$NON-NLS-1$ //$NON-NLS-2$could be rewritten to
return getFoo(
"a", //$NON-NLS-1$
// note that the index is updated from 2 to 1 after a line split
"b") //$NON-NLS-1$There was a problem hiding this comment.
Ok. I think for the sake of simplicity, we're going to have to force the comments to come right after each string literal + random other language tokens that are attached to it unbreakably (like ,;)), and always give them a $NON-NLS-1$ tag as a result. Otherwise we can't be sure, at the level where we process this, that the lines won't be broken later.
How does that sound?
There was a problem hiding this comment.
Sounds reasonable to me :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
NON-NLS more difficult example
==COMMIT_MSG==