Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline annotation args #191

Merged
merged 2 commits into from
Feb 13, 2020
Merged

inline annotation args #191

merged 2 commits into from
Feb 13, 2020

Conversation

dansanduleac
Copy link
Contributor

Before this PR

Long annotation args would be split onto the next line.

After this PR

==COMMIT_MSG==
Long annotation args are now partially inlined, such that concatenated strings look better.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Feb 13, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Long annotation args are now partially inlined, such that concatenated strings look better.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is nice!

@dansanduleac dansanduleac merged commit 08684cb into develop Feb 13, 2020
@dansanduleac dansanduleac deleted the ds/inline-annotation-args branch February 13, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants