Improvement: IntelliJ plugin with configurable implementation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
reviewed
Oct 14, 2019
...le-palantir-java-format/src/main/groovy/com/palantir/javaformat/gradle/JavaFormatPlugin.java
Outdated
Show resolved
Hide resolved
iamdanfox
reviewed
Oct 14, 2019
...le-palantir-java-format/src/main/groovy/com/palantir/javaformat/gradle/JavaFormatPlugin.java
Outdated
Show resolved
Hide resolved
ferozco
approved these changes
Oct 15, 2019
| version = "191.5849.21" | ||
| pluginName = "palantir-java-format" | ||
| updateSinceUntilBuild = true | ||
| version = "191.5849.21" |
There was a problem hiding this comment.
do we want to set this to 2019.1 or 2019.2 so we're testing against latest?
idea-plugin/build.gradle
Outdated
| version = project.version | ||
| sinceBuild = '173' | ||
| untilBuild = '' | ||
| pluginDescription = "Formats source code using the palantir-java-format tool. This version of " + |
There was a problem hiding this comment.
Description is a little lame now that the version can be configured
idea-plugin/build.gradle
Outdated
| } | ||
|
|
||
| publishPlugin { | ||
| token = project.ext.properties.jetbrainsPluginRepoToken | ||
| token = project.ext.properties.jetbrainsPluginRepoToken |
There was a problem hiding this comment.
do we need this? do we plan on publishing to intellij?
| @@ -102,5 +128,17 @@ public String getEnabled() { | |||
| return null; | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
There was a problem hiding this comment.
we should update or remove this
ferozco
approved these changes
Oct 15, 2019
ferozco
approved these changes
Oct 15, 2019
|
@dansanduleac and I have been pairing to try and make the |
iamdanfox
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The idea-plugin just bundles the current version of the formatter.
However, the plugin version is global to an IntelliJ installation, so all projects would be forced to use that version of the formatter. This is bad because IntelliJ formatting could get out of sync with
./gradlew formatAfter this PR
==COMMIT_MSG==
IntelliJ plugin can be automatically configured with a custom version of the formatter, by applying
com.palantir.java-formatin gradle and setting thepalantirJavaFormat.implementationVersion.==COMMIT_MSG==
In order to achieve this, we've separated palantir-java-format-api out of the formatter. This is a super thin API layer, and the implementation is found by service loading it out of the implementation jar.
Possible downsides?