service load only once #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
reviewed
Jan 28, 2020
| import com.google.common.collect.Iterables; | ||
| import com.palantir.javaformat.java.FormatterService; | ||
| import java.net.MalformedURLException; | ||
| import java.net.URL; | ||
| import java.net.URLClassLoader; | ||
| import java.util.ServiceLoader; | ||
| import java.util.function.Supplier; | ||
| import org.gradle.api.artifacts.Configuration; | ||
|
|
||
| public class JavaFormatExtension { |
There was a problem hiding this comment.
👍 confirmed this is only registered by the PalantirJavaFormatProvider plugin, which only works on the root project:
Preconditions.checkState(
rootProject == rootProject.getRootProject(),
"May only apply com.palantir.java-format-provider to the root project");
iamdanfox
approved these changes
Jan 28, 2020
|
Released 0.3.18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
spotless is service loading the implementation once per gradle project, even though it's guaranteed to be the same for the entire gradle build.
This leads to some people's gradles dying by exceeding MaxMetaspaceSize.
After this PR
==COMMIT_MSG==
Only service load the formatter implementation once.
==COMMIT_MSG==
Possible downsides?