don't inline new Class without class body #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
An early change allows inlining an expression if the last level is a constructor call e.g.
new SomeClass
. This is good for anonymous classes, as we can inline thenew SomeClass()
bit and let the body use the next lines.However, it's not good for new class expressions without a custom body, because it ends up allowing an inlining that breaks at the new class' parameters, e.g.
After this PR
==COMMIT_MSG==
Don't inline constructor calls without a custom body (i.e. if they are not anonymous classes).
Fixes #153.
==COMMIT_MSG==
Possible downsides?