Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle actions on save config correctly across IntelliJ versions #1112

Merged

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented Aug 5, 2024

Before this PR

In #1110, I attempted to fix the formatter not being enabled for Actions on Save in 2024.1. However, it appears this broke people using <=2023.3.6, as the defaults for myRunOnSave and myAllFileTypesSelected had changed between 2023.3.6 and 2023.3.7.

After this PR

==COMMIT_MSG==
Ensure Actions on Save is configured properly in IntelliJ <=2023.3.6
==COMMIT_MSG==

I tested on IntelliJ 2024.1.4 and 2023.2.7. We now make the config in a way that should not be ambiguous in either IDE version.

Possible downsides?

This doesn't work with some other version of intellij.

@CRogers CRogers requested a review from felixdesouza August 5, 2024 17:55
@changelog-app
Copy link

changelog-app bot commented Aug 5, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Ensure Actions on Save is configured properly in IntelliJ <=2023.3.6

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 31e3355 into develop Aug 5, 2024
7 checks passed
@bulldozer-bot bulldozer-bot bot deleted the callumr/fix-on-save-for-multiple-versions-of-intellij branch August 5, 2024 17:58
@svc-autorelease
Copy link
Collaborator

Released 2.49.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants