Expose fuzzy search #1002
Merged
Expose fuzzy search #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "$startsWith": string; | ||
| "$containsAllTermsInOrder": string; | ||
| "$containsAnyTerm": string; | ||
| "$containsAllTerms": string; | ||
| "$containsAnyTerm": string | { term: string; fuzzySearch?: boolean }; |
There was a problem hiding this comment.
Can we expose somewhere what fuzzySearch means? Not sure if dev console docs is best or if we need inline.
There was a problem hiding this comment.
Also not sure do we need @internal?
There was a problem hiding this comment.
Talked offline, I think those should go in dev console for now, and then we can think about JS doc'ing all these filter types inline later
There was a problem hiding this comment.
Also, removing export for now
nihalbhatnagar
previously approved these changes
Nov 21, 2024
policy-bot
bot
dismissed
nihalbhatnagar’s stale review
Invalidated by push of 1a84ab2
nihalbhatnagar
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing option to turn on fuzzy searching