[fix] 'useInsensitiveEnums' feature flag fully restores old behaviour #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
commented
Feb 18, 2019
| @@ -75,7 +74,6 @@ public static InsensitiveEnum valueOf(String value) { | |||
| case "ONE_HUNDRED": | |||
| return ONE_HUNDRED; | |||
| default: | |||
| ConjureEnums.validate(value); | |||
| return new InsensitiveEnum(Value.UNKNOWN, value); | |||
There was a problem hiding this comment.
You can see this matches the pre 2.8.0 behaviour, where no validation is performed in the UNKNOWN case.
dansanduleac
approved these changes
Feb 18, 2019
bulldozer-bot
bot
deleted the
dfox/fully-restore-case-insensitive-enums
branch
jcvitanovic
reviewed
Feb 18, 2019
| @Test | ||
| public void testInsensitiveEnum_unknownToleratesEmptyStringsForHistoricalReasons() { | ||
| InsensitiveEnum value = InsensitiveEnum.valueOf(""); | ||
| assertThat(value.get()).isEqualTo(InsensitiveEnum.Value.UNKNOWN); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
@jcvitanovic reported problems on an internal product where empty strings were persisted to a database, but trying to opt in to the old behaviour using this feature flag would still break.
After this PR
The feature flag brings back exactly the old pre-2.8.0 behavour, where strings are leniently deserialized.
A full revert is still being considered here: #238