Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default CAs are namespaced and accessed via a relative path #2906

Merged
merged 2 commits into from
May 15, 2024

Conversation

carterkozak
Copy link
Contributor

This allows the keystores jar to be shaded without breaking functionality.

==COMMIT_MSG==
The default CAs are namespaced and accessed via a relative path, allowing the keystores library to be shaded
==COMMIT_MSG==

Possible downsides?

It's possible that somebody attempts to load the underlying resource directly from this jar, however that is not a supported workflow.

This allows the `keystores` jar to be shaded without breaking
functionality.
@changelog-app
Copy link

changelog-app bot commented May 15, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The default CAs are namespaced and accessed via a relative path, allowing the keystores library to be shaded

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak carterkozak requested a review from bjlaub May 15, 2024 19:19
@bulldozer-bot bulldozer-bot bot merged commit 2d201fb into develop May 15, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/default_cas_relative branch May 15, 2024 19:40
@svc-autorelease
Copy link
Collaborator

Released 8.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants