Reduce the default conjure connect timeout to 5 seconds (from 10) #2777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
10 second default connect timeout.
After this PR
==COMMIT_MSG==
Reduce the default conjure connect timeout to 5 seconds (from 10)
==COMMIT_MSG==
Possible downsides?
Oh goodness yes! If clients are interacting with tremendously latent servers which are expected to take longer than 5 seconds to connect, attempts to connect may fail. However, our metrics make it clear that is not something to expect, and happens rarely+intermittently enough that failing early + retrying will provide a better user experience. In the off-chance that longer times are expected, clients may be configured with larger connect-timeout values. Ultimately it would be ideal if we reduced connect timeout values below 1 seconds.