Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always load certificates from the same jar as the code #2721

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

walkerburgin
Copy link
Contributor

Before this PR

We occasionally hit errors like this while initializing clients in threads with context class loaders:

Caused by: java.lang.IllegalArgumentException: resource ca-certificates.crt not found.
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:218)
        at com.google.common.io.Resources.getResource(Resources.java:196)
        at com.palantir.conjure.java.config.ssl.DefaultCas.getTrustedCertificates(DefaultCas.java:57)

After this PR

Always load the certificates from the same jar as the code.

Possible downsides?

None that I'm aware of.

@changelog-app
Copy link

changelog-app bot commented Oct 26, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Always load certificates from the same jar as the code

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit d813ca3 into develop Oct 26, 2023
@bulldozer-bot bulldozer-bot bot deleted the wburgin/10-26-23-class-loaders branch October 26, 2023 23:21
@svc-autorelease
Copy link
Collaborator

Released 7.65.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants