Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle-git-version from 0.15.0 to 3.0.0 #2604

Closed
wants to merge 2 commits into from

Conversation

ash211
Copy link
Contributor

@ash211 ash211 commented Apr 20, 2023

Before this PR

Running ./gradlew classes testClasses on my local checkout fails with org.eclipse.jgit.errors.CorruptObjectException: DIRC checksum mismatch because newer versions of the git binary produce checkouts that older versions of jgit do not support. All repos using gradle-git-version will need this bump.

After this PR

==COMMIT_MSG==
Bump gradle-git-version from 0.15.0 to 3.0.0
==COMMIT_MSG==

@ash211 ash211 requested a review from schlosna April 20, 2023 22:14
@ash211 ash211 requested a review from carterkozak April 20, 2023 22:17
@@ -13,7 +13,7 @@ buildscript {
classpath 'com.palantir.gradle.revapi:gradle-revapi:1.7.0'
classpath 'com.netflix.nebula:gradle-dependency-lock-plugin:7.0.1'
classpath 'com.palantir.baseline:gradle-baseline-java:5.7.0'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.15.0'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:3.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ash211 do you know why this wasn't excavated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2432 got stuck

@carterkozak
Copy link
Contributor

Let's fix the excavator instead

@ash211 ash211 closed this Apr 20, 2023
@ash211 ash211 deleted the aash/bump-git-version branch April 20, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants