Replace aged afterburner with the sr71 blackbird module #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Afterburner uses several internal methods which result in warnings in modern jdks, and result in failures using jdk16+. The replacement Blackbird module uses LambdaMetafactory for a more sustainable solution. Documentation: https://github.com/FasterXML/jackson-modules-base/tree/2.13/blackbird#jackson-blackbird
Generate changelog in
|
fawind
approved these changes
Jul 6, 2021
|
Released 7.6.0 |
carterkozak
added a commit
to palantir/atlasdb
that referenced
this pull request
Jul 6, 2021
See palantir/conjure-java-runtime#2022 Afterburner uses several internal methods which result in warnings in modern jdks, and result in failures using jdk16+. The replacement Blackbird module uses LambdaMetafactory for a more sustainable solution. Documentation: https://github.com/FasterXML/jackson-modules-base/tree/2.13/blackbird#jackson-blackbird
|
@carterkozak I vaguely recall the folks who work on our internal auth'd elasticsearch caring a lot about how fast serde is... do we have any predictions about how fast blackbird is compared to afterburner?? (is it the same codegen just loaded in a different way? or a whole different approach) |
|
More or less equivalent, except that it only applies to method calls and not direct field access. Fortunately conjure exclusively uses methods. There may be some variation in types with annotated fields, but I don't expect it to be substantial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afterburner uses several internal methods which result in warnings in
modern jdks, and result in failures using jdk16+.
The replacement Blackbird module uses LambdaMetafactory for a more
sustainable solution.
Documentation:
https://github.com/FasterXML/jackson-modules-base/tree/2.13/blackbird#jackson-blackbird
==COMMIT_MSG==
Replace aged afterburner with the sr71 blackbird module
==COMMIT_MSG==
Possible downsides?
Sometimes jackson changes can be brittle, it's possible bugs exist in the blackbird module that weren't present in afterburner. We have a great deal of test coverage, so I'm not worried as long as tests pass.