InstrumentedInterceptorTest is more robust

palantir · Apr 20, 2023 · b23f011 · b23f011
1 parent 710149b
commit b23f011
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/...p-clients/src/test/java/com/palantir/conjure/java/okhttp/InstrumentedInterceptorTest.java b/...p-clients/src/test/java/com/palantir/conjure/java/okhttp/InstrumentedInterceptorTest.java
@@ -24,7 +24,6 @@
 import com.google.common.collect.Collections2;
 import com.google.common.collect.Iterables;
 import com.palantir.tritium.metrics.registry.DefaultTaggedMetricRegistry;
-import com.palantir.tritium.metrics.registry.MetricName;
 import com.palantir.tritium.metrics.registry.TaggedMetricRegistry;
 import java.io.IOException;
 import java.util.Collection;
@@ -82,13 +81,7 @@ public void testResponseFamilyMetrics() throws IOException {
 
     @Test
     public void testResponseMetricRegistered() throws IOException {
-        MetricName name = MetricName.builder()
-                .safeName("client.response")
-                .putSafeTags("service-name", "client")
-                .putSafeTags("libraryName", "conjure-java-runtime")
-                .putSafeTags("libraryVersion", "unknown")
-                .build();
-        Timer timer = registry.timer(name);
+        Timer timer = ClientMetrics.of(registry).response("client");
 
         assertThat(timer.getCount()).isZero();