Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebump JNA with LIBFFI_TMPDIR #443

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

wi11dey
Copy link
Contributor

@wi11dey wi11dey commented Sep 14, 2023

This reverts commit 5816ffc.

build.xml Outdated
@@ -416,7 +416,7 @@
<exclusion groupId="hsqldb" artifactId="hsqldb"/> <!-- outdated version -->
<exclusion groupId="antlr" artifactId="antlr"/> <!-- outdated version -->
</dependency>
<dependency groupId="net.java.dev.jna" artifactId="jna" version="4.0.0"/>
<dependency groupId="net.java.dev.jna" artifactId="jna" version="5.8.0"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be at least 5.10.0 to pick up the fix java-native-access/jna#1378

Suggested change
<dependency groupId="net.java.dev.jna" artifactId="jna" version="5.8.0"/>
<dependency groupId="net.java.dev.jna" artifactId="jna" version="5.13.0"/>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump JNA to at least 5.10.0, although latest is 5.13.0, see https://github.com/java-native-access/jna/blob/master/CHANGES.md

@wi11dey wi11dey requested a review from schlosna September 14, 2023 15:32
@wi11dey
Copy link
Contributor Author

wi11dey commented Sep 14, 2023

SHA256 of jna-5.13.0.jar: 66d4f819a062a51a1d5627bffc23fac55d1677f0e0a1feba144aabdd670a64bb
SHA1 of jna-5.13.0.jar from maven: 1200e7ebeedbe0d10062093f32925a912020e747
@rhuffy

@schlosna
Copy link
Contributor

SHA1 of jna-5.13.0.jar from maven: 1200e7ebeedbe0d10062093f32925a912020e747

Validated https://github.com/palantir/cassandra/raw/3c64de216ed4079d5ce2be8936599aa278a7439c/lib/jna-5.13.0.jar against https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.13.0/jna-5.13.0.jar.sha1 and locally

$ shasum -a 1 jna-5.13.0.jar
1200e7ebeedbe0d10062093f32925a912020e747  jna-5.13.0.jar

@wi11dey
Copy link
Contributor Author

wi11dey commented Sep 20, 2023

Tested Cassandra is booting up healthy even when tmpfs is mounted noexec

@zpear zpear merged commit c504dc3 into palantir-cassandra-2.2.18 Sep 26, 2023
@svc-autorelease
Copy link
Collaborator

Unable to release palantir-cassandra-2.2.18 since the branch protections rules include administrators. Please modify the rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants