Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot fails to interpret .bulldozer.yml #304

Closed
dB2510 opened this issue Apr 5, 2022 · 2 comments
Closed

Bot fails to interpret .bulldozer.yml #304

dB2510 opened this issue Apr 5, 2022 · 2 comments

Comments

@dB2510
Copy link

dB2510 commented Apr 5, 2022

I have deployed bulldozer bot to our kubernetes cluster and here is my .bulldozer.yml that is present in our repo:

version: 1

merge:
  trigger:
    labels: ["merge when ready"]
    comment_substrings: ["==MERGE_WHEN_READY=="]
    branches: ["main"]
  ignore:
    labels: ["do not merge"]
    comment_substrings: ["==DO_NOT_MERGE=="]
  method: squash
  options:
    squash:
      title: "github_default_title"
      body: pull_request_body
  delete_after_merge: true
  allow_merge_with_no_checks: false

update:
  trigger:
    labels: ["wip", "update me"]

From k8s logs, it seems that it identifies that .bulldozer.yml is present but fails to react accordingly. As soon as a PR is opened it merges it without any label or comment.

Any ideas what could be causing this?

@bluekeyes
Copy link
Member

I think this is because of the branches: ["main"] trigger. Bulldozer will attempt to merge a pull request if any trigger condition is true. My guess is that your pull requests targeted the main branch, so Bulldozer merged them without waiting for the label or comment.

You should be able to confirm this by enabling debug logging and looking for messages that contain triggered because triggering is enabled. The rest of the message includes the reason that the PR was triggered.

@dB2510
Copy link
Author

dB2510 commented Apr 6, 2022

@bluekeyes Yes, I found this message triggered because triggering is enabled in logs. I removed this trigger and it worked as expected which does makes sense.
Thanks!
Closing this issue.

@dB2510 dB2510 closed this as completed Apr 6, 2022
obol-bulldozer bot pushed a commit to ObolNetwork/charon that referenced this issue Apr 6, 2022
Removed target branch trigger, and updated label and comment trigger. This issue was letting bulldozer bot to merge any PR if the target is main. Ref: palantir/bulldozer#304

category: bug
ticket: #325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants