Tweak readme's. Add simpler npm scripts to avoid npm install -g #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
suggested changes
Nov 11, 2016
|
|
||
| [](https://www.npmjs.com/package/@blueprintjs/core) – Core styles & components for the UI kit. | ||
|
|
||
| [](https://www.npmjs.com/package/@blueprintjs/datetime) – Date & time UI components. | ||
| [](https://www.npmjs.com/package/@blueprintjs/datetime) – Date & time UI component. |
There was a problem hiding this comment.
👎 there are many components in this package
|
|
||
| [](https://www.npmjs.com/package/@blueprintjs/table) – Scalable interactive table UI components. | ||
| [](https://www.npmjs.com/package/@blueprintjs/table) – Scalable interactive table UI component. |
There was a problem hiding this comment.
again, package defines several components.
i struggle with how to explain the table library, because there is a component called Table but you also need several others to even get started (Cell, etc).
| @@ -4,7 +4,7 @@ Blueprint is a React UI toolkit for the Web. | |||
|
|
|||
| This package contains the core set of UI components as CSS and React code. | |||
|
|
|||
| ## Usage | |||
| ## Installations | |||
| @@ -1,4 +1,4 @@ | |||
| # [Blueprint](http://blueprintjs.com/) Date & Time Components | |||
| # [Blueprint](http://blueprintjs.com/) Date & Time Component | |||
| @@ -1,4 +1,4 @@ | |||
| # [Blueprint](http://blueprintjs.com/) Table Components | |||
| # [Blueprint](http://blueprintjs.com/) Table Component | |||
There was a problem hiding this comment.
plural? not sure about this one
There was a problem hiding this comment.
✅ spoke offline, this is legit
|
|
||
| ``` | ||
| npm install --save @blueprintjs/table | ||
| npm install --save @blueprintjs/core @blueprintjs/table |
There was a problem hiding this comment.
table depends on core so it's not necessary to install explicitly.
unless we want to encourage this behavior, for version sanity?
|
|
||
| ``` | ||
| npm install --save @blueprintjs/datetime | ||
| npm install --save @blueprintjs/core @blueprintjs/datetime |
There was a problem hiding this comment.
datetime depends on core which is why i didn't do this in the first place.
giladgray
approved these changes
Nov 11, 2016
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
…ntir#81) * Tweak readme's. Add simpler npm scripts to avoid npm install -g * PR Comments * One more pluralization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.