Add :disabled support for pt-file-upload #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorca
reviewed
Feb 22, 2017
| @@ -84,6 +84,14 @@ $control-group-stack: ( | |||
| } | |||
| } | |||
|
|
|||
| @mixin pt-input-disabled() { | |||
There was a problem hiding this comment.
Mixins don't need to come before they're declared. Similar to what we do for buttons, I prefer having pt-input() first followed by its modifiers pt-input-<modifier>()
llorca
reviewed
Feb 22, 2017
giladgray
approved these changes
Feb 23, 2017
| } | ||
|
|
||
| .pt-button-spinner .pt-spinner-head { | ||
| stroke: $dark-progress-head-color; | ||
| } | ||
| } | ||
|
|
||
| @mixin pt-dark-button-intent-disabled() { |
There was a problem hiding this comment.
I'm not crazy about adding four new mixins to this file, but I get it. I wonder if it's reasonable to just add some params to the first disabled mixin for color and background?
llorca
approved these changes
Feb 23, 2017
|
@cmslewis merge conflicts ahead! |
|
Verified that buttons, text inputs, and file upload all look good on Chrome/FF/Safari/IE. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689
Checklist
Changes proposed in this pull request:
:disabledonpt-file-uploadpt-button/pt-inputdisabled styles into reusable mixins:disabledstate.Reviewers should focus on:
Screenshot
Also, buttons are visually unchanged:
And inputs are visually unchanged: