Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter-sort-asc and filter-sort-desc Icons #7083

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

donghee214
Copy link
Contributor

@donghee214 donghee214 commented Nov 20, 2024

Changes proposed in this pull request:

Add filter-sort-asc, and filter-sort-desc icons

image

image

@changelog-app
Copy link

changelog-app bot commented Nov 20, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add sort-asc-filter and sort-desc-filter Icons

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

add icons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

packages/icons/icons.json Outdated Show resolved Hide resolved
resources/icons/16px/sort-asc-filter.svg Outdated Show resolved Hide resolved
resources/icons/16px/sort-desc-filter.svg Outdated Show resolved Hide resolved
resources/icons/20px/sort-asc-filter.svg Outdated Show resolved Hide resolved
resources/icons/20px/sort-desc-filter.svg Outdated Show resolved Hide resolved
@donghee214 donghee214 changed the title Add sort-asc-filter and sort-desc-filter Icons Add filter-sort-asc and filter-sort-desc Icons Nov 21, 2024
@svc-palantir-github
Copy link

clean up

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Merge branch 'develop' into dkim/filter-sort

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@donghee214 donghee214 merged commit 1d1579d into develop Nov 21, 2024
13 checks passed
@donghee214 donghee214 deleted the dkim/filter-sort branch November 21, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants