Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KeyComboTag): Style regression #7063

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(KeyComboTag): Style regression #7063

merged 1 commit into from
Nov 13, 2024

Conversation

jscheiny
Copy link
Contributor

Fixes #7025

Changes proposed in this pull request:

Fixed a regression from a previous PR where we removed the flex container from minimal keycombo tags meaning that UIs could be misaligned.

Screenshot

Confirmed that keycombos look good for both platforms still:
Screenshot 2024-11-13 at 1 00 53 PM

@changelog-app
Copy link

changelog-app bot commented Nov 13, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix(KeyComboTag): Style regression

Check the box to generate changelog(s)

  • Generate changelog entry

@jscheiny jscheiny marked this pull request as ready for review November 13, 2024 18:04
@svc-palantir-github
Copy link

fix(KeyComboTag): Style regression

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@jscheiny jscheiny merged commit 96f1ae4 into develop Nov 13, 2024
12 of 14 checks passed
@jscheiny jscheiny deleted the js/fix-keycombos branch November 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants