Fix hotkeys dialog having 2 scrollbars

[okaynik]

Fixes #0000

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

Fix hotkey dialog having 2 scrollbars.

Reviewers should focus on:

Both hotkey-column and dialog-body-scroll-container have overflow: auto property. Add DialogBody to HotkeysDialogLegacy and remove overflow: scroll from hotkey-column.

Screenshot

Before	After

[changelog-app]

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Fix hotkeys dialog having 2 scrollbars

Check the box to generate changelog(s)

• Generate changelog entry

[svc-palantir-github]

fix hotkeys dialog having 2 scrollbars

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[michael-yx-wu]

I cannot quite repro the before state on the current version of the docs with the scrollbars displayed side-by-side, although I do see two scrollbars overlapped on top of each other briefly and can confirm that scrolling doesn't work well because of the two scrollbars.

Instead of disabling the scroll container on DialogBody, can you instead add a DialogBody to the legacy implementation. Replacing this line with the actual component:

blueprint/packages/core/src/legacy/hotkeysDialogLegacy.tsx

Line 128 in 0f8d6d9

<div className={Classes.DIALOG_BODY}>{this.renderHotkeys()}</div>

Then we could probably just remove these styles from the HOTKEY_COLUMN class

blueprint/packages/core/src/components/hotkeys/_hotkeys.scss

Lines 27 to 28 in 0f8d6d9

	max-height: 80vh;
	overflow-y: auto;

[svc-palantir-github]

fix 2 scrollbars

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[ericjeney]

Thanks! I was able to confirm this by setting "Show scroll bars" to "Always" in macOS's System Settings.