PanelStack2: Prevent extra render due to updated previous panel #6713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had a
TextArea
component with a jumping cursor from the moment I updated to Blueprint 5 from 4.This component is located in a second panel within a
PanelStack2
but the first one had changing props at every render.When digging through the differences between v4 and v5, I found out that
handleClose
has been added to theuseMemo
dependencies ofPanelWrapper
triggering a render every timepreviousPanel
changes.So for now, to go around this, I wrap the previous panel with a
useMemo
as well.Checklist
Changes proposed in this pull request:
Extracting
previousPanel !== undefined
outside the callback prevent extra renders by using a boolean instead.