[core] fix(Popover): return focus to target on ESC keypress #6587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Popover
): improve keyboard a11y: always return focus to target element when an ESC keypress closes the popoverReviewers should focus on:
Updated behavior in docs example.
Note that we need to be conservative here and not enable this behavior for all keyboard interactions because there may be some interactions where a confirmation action (e.g. "Enter" key) on a "popover dismiss element" (like a MenuItem) pulls the user's focus away from the popover, and we don't want to break that kind of functionality.
Screenshot
Returns focus on ESC key:
Does not return focus (previous behavior) on Enter key: