Clean up button files #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmslewis
approved these changes
Feb 9, 2017
giladgray
reviewed
Feb 9, 2017
| @@ -65,6 +66,10 @@ Styleguide components.button.css | |||
| @each $intent, $colors in $button-intents { | |||
| &.pt-intent-#{$intent} { | |||
| @include pt-button-intent($colors...); | |||
|
|
|||
| .pt-button-spinner .pt-spinner-head { | |||
There was a problem hiding this comment.
why is this inside the @each loop but the dark block on line 178 below isn't?
much preferable to define this static rule once instead of redefining for each intent.
giladgray
suggested changes
Feb 9, 2017
|
@giladgray is this good to merge now? Looks like @llorca addressed the question above. |
giladgray
approved these changes
Feb 22, 2017
# Conflicts: # packages/core/src/components/button/_common.scss
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
extendusage