-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up tooltips by default #640
Conversation
This becomes a problem once you start having tooltip in more complicated components (eg. tables and graphs) - granted those can reset the default themselves but I'm curious on the reasoning when a delay is also pretty standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting 🤔 ours does feel a little slow but zero may be too snappy. |
I'm happy with faster transitions but 0 delay doesn't work imo. You want them fast enough but also delayed enough so that you don't trigger them constantly as you move your mouse. |
@@ -155,7 +155,7 @@ export class Tooltip extends React.Component<ITooltipProps, {}> { | |||
interactionKind={PopoverInteractionKind.HOVER_TARGET_ONLY} | |||
lazy={true} | |||
popoverClassName={classes} | |||
transitionDuration={200} | |||
transitionDuration={transitionDuration} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check that this is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the better thing to do is to remove this line entirely cuz it's covered by {...this.props}
spread
Hover delay 100ms How's that? |
I like 100/100 |
How about a way for us to set the default site-wide? I'm looking at having to wrap everywhere in my app with a version with a hardcoded default. |
@noah79 sounds like a constant to me. we'd be happy to discuss such a feature but I make no promises, as we have no precedent for globally modifying defaults like this. but wait! have you tried something like Blueprint.Core.Tooltip.defaultProps.hoverOpenDelay = MY_MAGIC_VALUE; |
^ simply modifying the default prop value (which is already a static constant) seems like the correct answer for your use case (though I've never tried modifying static component members like this). |
hoverOpenDelay
to0
Thoughts? cc @adidahiya @pkwi @thisisalessandro