[core] feat(Text): forward ref to DOM element #6331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclockard
commented
Aug 25, 2023
Comment on lines
+23
to
+26
| export interface TextProps | ||
| extends Props, | ||
| React.RefAttributes<HTMLElement>, | ||
| Omit<React.HTMLAttributes<HTMLElement>, "title"> { |
There was a problem hiding this comment.
Changed this to better match other Prop interfaces elsewhere in the code base.
adidahiya
changed the title
adidahiya
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6320
Checklist
Changes proposed in this pull request:
Makes it so that the
Textcomponent forwards a ref to the underlying HTML element.Reviewers should focus on:
Correctly following patterns of the rest of the code base