Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename timezone Kiev to Kyiv #6302

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Rename timezone Kiev to Kyiv #6302

merged 2 commits into from
Jul 25, 2023

Conversation

MorganFH
Copy link
Contributor

@MorganFH MorganFH commented Jul 25, 2023

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Rename the timezone Kiev to Kyiv.

https://en.wikipedia.org/wiki/Kyiv

The preferred English spelling of the capital of Ukraine is Kyiv. This spelling derives from the Ukranian language, whereas Kiev derives from the Russian language.

Reviewers should focus on:

Screenshot

Before
image

After
image

@adidahiya
Copy link
Contributor

Rename timezone Kiev to Kyiv

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@MorganFH MorganFH requested a review from adidahiya July 25, 2023 11:33
@adidahiya
Copy link
Contributor

Keep old ianaCode

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, thanks @MorganFH!

@adidahiya adidahiya merged commit 983e79d into develop Jul 25, 2023
@adidahiya adidahiya deleted the kyiv-not-kiev branch July 25, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants