Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordsmith docs overview page #613

Merged
merged 3 commits into from
Feb 3, 2017
Merged

Wordsmith docs overview page #613

merged 3 commits into from
Feb 3, 2017

Conversation

adidahiya
Copy link
Contributor

No description provided.

@blueprint-bot
Copy link

Wordsmith docs overview page

Preview: docs
Coverage: core | datetime

@cmslewis
Copy link
Contributor

cmslewis commented Feb 3, 2017

Let's edit the repo description in Github too?

image

And on the landing page:

image

@adidahiya
Copy link
Contributor Author

@cmslewis updated the landing page. I'll update the repo description when this merges.

@blueprint-bot
Copy link

Update index.html

Preview: docs | landing
Coverage: core | datetime

of JavaScript that compiles to plain JavaScript. Many of the code samples throughout this site and
all interactive examples are also written in TypeScript. TypeScript code looks exactly like ES2015
of JavaScript that compiles to plain JavaScript. All the code samples throughout this site and
all interactive examples are also written in TypeScript. TypeScript code looks exactly like ES2015+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the + for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because there's ES2016, ES2017...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's what i thought, just looked like a typo at first

Use the [__blueprintjs__ tag on Stack Overflow](http://stackoverflow.com/questions/tagged/blueprintjs)
for support requests.

Releases are tagged and documented [here on Github](https://github.com/palantir/blueprint/releases)
(more info about releases [on the wiki](https://github.com/palantir/blueprint/wiki/Releases-&-Artifacts)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this wiki page does not exist

Copy link
Contributor Author

@adidahiya adidahiya Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this PR, also I mentioned that here #5 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists internally, I looked at it, seems pretty unnecessary and out-of-date. Let's remove this now?

@@ -1,16 +1,18 @@
Blueprint is a React UI toolkit for the web.
Blueprint is a React-based UI toolkit for the web.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's way cleaner without the verboseness of the "-based" (not really necessary). If you feel strongly, I'm cool with here, but I prefer keeping the tagline everywhere as is for now. Note that changing it in this file only isn't enough, there are other places where it appears on GitHub, the landing, different services... Let's wait for 2.0 please, and we can work out and even better one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I'm the only one thinking like this, so nevermind.

Can you make sure you caught all instances of that tagline and that it's changed everywhere?

Use the [__blueprintjs__ tag on Stack Overflow](http://stackoverflow.com/questions/tagged/blueprintjs)
for support requests.

Releases are tagged and documented [here on Github](https://github.com/palantir/blueprint/releases)
(more info about releases [on the wiki](https://github.com/palantir/blueprint/wiki/Releases-&-Artifacts)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists internally, I looked at it, seems pretty unnecessary and out-of-date. Let's remove this now?

The Blueprint team maintains multiple packages of styles and JavaScript components on NPM (in the scope
`@blueprintjs`). These are listed in the header under _Releases_. They can be installed with
similar commands as above. Once you've included any additional package(s) in your application, explore the
Blueprint is a collection of packages of styles and JavaScript components—the full list appears in this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First read I thought the "full list" referred to the "components" and not the "packages". Suggestion: the full list appears -> those packages appear?

@giladgray giladgray added the P0 label Feb 3, 2017
@blueprint-bot
Copy link

blueprint-bot commented Feb 3, 2017

remove wiki link, clarify package list wording

Preview: docs | landing
Coverage: core | datetime

@giladgray giladgray removed the P0 label Feb 3, 2017
@giladgray giladgray merged commit ca5e650 into master Feb 3, 2017
@giladgray giladgray deleted the ad/docs-overview branch February 3, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants