[icons] feat: new icons "rectangle", "symbol-rectangle" #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Mar 1, 2022
There was a problem hiding this comment.
looking back at existing shape icons (circle, square), some of the groupings / categorizations feel a little arbitrary / inconsistent... but I think the best thing to in this case is to match the other "square" icons
icons look good in the docs preview, we just need to clean up the metadata
Co-authored-by: Adi Dahiya <[email protected]>
Co-authored-by: Adi Dahiya <[email protected]>
adidahiya
approved these changes
Mar 1, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
New icon for rectangle
Reviewers should focus on:
everything renders ok and right files are changed
Screenshot