Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popover2] feat: ContextMenu2 component #4524

Merged
merged 8 commits into from
Feb 15, 2021
Merged

[popover2] feat: ContextMenu2 component #4524

merged 8 commits into from
Feb 15, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Feb 10, 2021 •
edited
Loading

Fixes #3891, fixes #4038

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

New <ContextMenu2> component, works with hooks, no more potentially confusing decorators, simply works with Popover2 under the hood...

Reviewers should focus on:

API parity

Screenshot

image

@blueprint-bot
Copy link

WIP ContextMenu2

Previews: documentation | landing | table

@blueprint-bot
Copy link

dark theme

Previews: documentation | landing | table

@adidahiya adidahiya marked this pull request as ready for review February 12, 2021 13:44
@blueprint-bot
Copy link

fix lint

Previews: documentation | landing | table

@blueprint-bot
Copy link

deprecate v1 API

Previews: documentation | landing | table

@adidahiya adidahiya merged commit 0162bc5 into develop Feb 15, 2021
@adidahiya adidahiya deleted the ad/context-menu-2 branch February 15, 2021 19:28
@adidahiya adidahiya mentioned this pull request Feb 16, 2021
Closed
@stevestorey
Copy link

stevestorey commented Feb 24, 2021 •
edited
Loading

I've been using the onNodeContextMenu property of the Tree class https://blueprintjs.com/docs/#core/components/tree to show a context menu on tree nodes by calling ContextMenu.show - https://blueprintjs.com/docs/#core/components/context-menu.imperative-usage - but that doesn't seem to be an API supported in the new ContextMenu2 component, and given I don't see a way to override the tree item renderer to be able to wrap the tree nodes in a <ContextMenu2> component, I'm not sure how best to migrate over.

How I can use the new ContextMenu2 to show context menus for tree nodes ?

thanks

@adidahiya
Copy link
Contributor Author

@stevestorey can you open a new issue? or tack onto this related one: #4537

@adidahiya adidahiya added this to the 4.0.0-beta.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-alpha.0
Development

Successfully merging this pull request may close these issues.

[core] isDarkTheme utility should be exported Unable to get ContextMenu working (HOC style)
3 participants
@adidahiya @blueprint-bot @stevestorey