fix Toast stacking #419
Merged
fix Toast stacking #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 5, 2017 14:01
this avoids leaking the mutation and allows more than one of each Toast to appear in the example.
so they also stack when `inline`. fixes #367
adidahiya
approved these changes
Jan 6, 2017
| @@ -89,6 +93,9 @@ export class Toaster extends AbstractComponent<IToasterProps, IToasterState> imp | |||
| * The `Toaster` will be rendered into a new element appended to the given container. | |||
| */ | |||
| public static create(props?: IToasterProps, container = document.body): IToaster { | |||
| if (props != null && props.inline != null) { | |||
There was a problem hiding this comment.
would prefer explicit checks against undefined; we don't really need to support nulls
There was a problem hiding this comment.
i'm just so used to doing it this way.
how about if we tackle that change across the codebase when we enable strictNullChecks?
There was a problem hiding this comment.
sure, but it won't get flagged for you automatically; you'll need to look for all such comparisons against null. in my ideal world, we also enable the no-null-keyword lint rule and any explicit usage of null would have to be whitelisted
There was a problem hiding this comment.
sure that sounds reasonable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #367
Checklist
Changes proposed in this pull request:
position: relativeso they also stack wheninline.Reviewers should focus on: