-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added !default to core colors #377
Conversation
Thanks for your interest in palantir/blueprint, @gregtillbrook! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Thanks @gregtillbrook! Let's keep this open, other team members will review in a couple weeks after the vacation 👍 |
+1! This would be great. |
some relevant conversation begins here: #396 (comment) i'm inclined to just ship this because it'll make consumption much easier for everyone. modifying the named colors will be frowned upon but i recognize that it's much simpler to just modify |
@gregtillbrook Circle is not reporting build status -- would you mind pushing an empty commit to try and trigger CI? |
@gregtillbrook if we don't hear from you by end of today, I'll take over this feature so we can ship it in tomorrow's release 👍 |
Is it possible to add |
@Santas, that also came up in the discussion on #396 and seems to have just been a missed line. @giladgray fixed it already in this commit, so I'd assume button-intents will have !default in the next release. |
Sorry I didn't reply - was on a long haul flight. Thanks for accepting this one! :) |
Small PR that adds !default to the core blueprint colors. I know this was discussed already internally by you folks but following discussion in #123 I thought Id create this PR incase you agreed with the line of reasoning there. If not, then please close/delete this PR :)
Sass lint is passing.