Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve examples "cannot find module" errors #332

Merged
merged 2 commits into from
Dec 8, 2016

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Dec 7, 2016

Changes proposed in this pull request:

  • added baseUrl and paths to docs tsconfig.json so it always looks in docs/node_modules for @blueprintjs packages. (thanks @ericanderson!)
  • webpack-compile-docs depends on docs alias to generate necessary data (allows standalone usage).

by adding `baseUrl` and `paths` to docs tsconfig.json so it always looks in docs node_modules for `@blueprintjs` packages.
thanks @ericanderson!
@blueprint-bot
Copy link

resolve examples "cannot find module" errors

Preview: docs
Coverage: core | datetime

so imports can be resolved in your editor.
@blueprint-bot
Copy link

add paths to examples tsconfig so imports can be resolved in your editor.

Preview: docs | landing
Coverage: core | datetime

@giladgray giladgray merged commit e746068 into master Dec 8, 2016
@giladgray giladgray deleted the gg/docs-examples-errors branch December 8, 2016 23:10
@giladgray giladgray mentioned this pull request Dec 9, 2016
greglo pushed a commit to greglo/blueprint that referenced this pull request Dec 12, 2016
* resolve examples "cannot find module" errors

by adding `baseUrl` and `paths` to docs tsconfig.json so it always looks in docs node_modules for `@blueprintjs` packages.
thanks @ericanderson!

* add paths to examples tsconfig
so imports can be resolved in your editor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants