Fix possibly mis-measured text width in DatePicker #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Dec 6, 2016
| private yearArrowRefHandler = (r: HTMLElement) => this.yearArrow = r; | ||
| private containerRefHandler = (r: HTMLElement) => this.containerElement = r; | ||
| private monthArrowRefHandler = (r: HTMLElement) => this.monthArrowElement = r; | ||
| private yearArrowRefHandler = (r: HTMLElement) => this.yearArrowElement = r; |
There was a problem hiding this comment.
unrelated: I would like to move to the following pattern for ref handlers:
private refHandlers = {
container: (r: HTMLElement) => this.containerElement = r,
monthArrow: ...,
yearArrow: ...,
};
There was a problem hiding this comment.
i'm accumulating a list of major refactors to datetime code, for the new year...
will add this!
giladgray
reviewed
Dec 6, 2016
| private yearArrow: HTMLElement; | ||
| private containerElement: HTMLElement; | ||
| private monthArrowElement: HTMLElement; | ||
| private yearArrowElement: HTMLElement; |
giladgray
approved these changes
Dec 6, 2016
|
This looks great. Thank you. I also like the refHandler pattern you're using. I was doing the gross
PS You guys above Hill Country? |
|
@paulpooch yes the what's this Hill Country? |
|
Hill Country was in reference to one of your NYC offices. |
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
* Add containerElement to measureTextWidth function signature * Create a ref handler for the container element, and pass the element in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316
Changes proposed in this pull request:
containerElementparameter toUtils.measureTextWidth(defaults todocument.body)DatePickerto ensure we're measuring text as sized within that componentReviewers should focus on:
*Elementsuffixes to each of the elements for clarity and consistency. The type handles that, but this makes things easier to read quickly at a glance.100pxand observing that the<DatePicker>dropdown arrows still appeared in the expected place.