Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Readme to add showcase link #2637

Closed
wants to merge 2 commits into from

Conversation

samarthdave
Copy link

The following is not a bug fix.

  • only read me updated

Changes proposed in this pull request:

Hi there!
I wanted to use a nice UI library for an upcoming project in Electron and since it doesn't need to scale to mobile, this works great!

However, I wanted to see all the components in one place. Here is a site that I built with surge.sh. It would be great if it could be added to the readme. Here is the github link to the repo.

Showcase (its pretty simple and a work in progress so please write recommendations):

blueprintjs.surge.sh

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @samarthdave! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@giladgray
Copy link
Contributor

@samarthdave thank you for taking the time to do this, but unfortunately this is not the kind of experience we want to promote, for a few reasons:

  1. the showcase code does not live with the actual library code so they will quickly get out of date.
  2. these examples do not conform to our usage guidelines so they encourage bad practices
  3. the showcase is not exhaustive -- it only covers a few of the components and none of the "interesting" ones like Dialog or Select
  4. finally, the documentation itself contains all this information and so much more. let's not fracture the ecosystem.

@giladgray giladgray closed this Jul 2, 2018
@samarthdave
Copy link
Author

Sounds good @giladgray . Just curious, do you have any pointers (in regards to #2) for bad/good practices?

Sorry, I'm just getting started with React so I'm a little new to this.
Thanks

@giladgray
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants