fixes: helperText no longer accepting React nodes #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @will-stone! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
giladgray
approved these changes
Mar 20, 2018
| @@ -42,7 +42,7 @@ export class Label extends React.PureComponent<ILabelProps, {}> { | |||
| return ( | |||
| <label {...htmlProps} className={rootClasses}> | |||
| {text} | |||
| {helperText && <span className={classNames(Classes.TEXT_MUTED)}>{" " + helperText}</span>} | |||
| {helperText && <span className={classNames(Classes.TEXT_MUTED)}>{" "}{helperText}</span>} | |||
There was a problem hiding this comment.
while we're at it, can you remove the classNames() call? not necessary for one class.
There was a problem hiding this comment.
@will-stone i went ahead and made this change here. thanks!
reiv
reviewed
Mar 20, 2018
| @@ -42,7 +42,7 @@ export class Label extends React.PureComponent<ILabelProps, {}> { | |||
| return ( | |||
| <label {...htmlProps} className={rootClasses}> | |||
| {text} | |||
| {helperText && <span className={classNames(Classes.TEXT_MUTED)}>{" " + helperText}</span>} | |||
| {helperText && <span className={Classes.TEXT_MUTED}>{" "}{helperText}</span>} | |||
There was a problem hiding this comment.
tslint/prettier is complaining about this line:
Replace {"·"} with ·
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2279
Changes proposed in this pull request:
The current implementation of helperText on Label only allows for text, this fixes the regression and allows for React nodes again.
Reviewers should focus on:
Adding React nodes as helperText