[Tags] Add pt-interactive support #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llorca merge |
giladgray
reviewed
Mar 15, 2018
| @@ -1,6 +1,9 @@ | |||
| // Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
| // Licensed under the terms of the LICENSE file distributed with this project. | |||
|
|
|||
| $tag-default-color: $gray1; | |||
| $dark-tag-default-color: $gray5; | |||
There was a problem hiding this comment.
add !default to both of these
Merge remote-tracking branch 'origin/develop' into al/tags-interactivePreview: documentation | landing | table |
|
i feel like minimal hover state is too strong compared to default state -- too big of a change. |
increase contrast of regular interactive tagsPreview: documentation | landing | table |
giladgray
reviewed
Mar 16, 2018
| @@ -48,7 +65,7 @@ export class Tag extends React.PureComponent<ITagProps, {}> { | |||
| ) : null; | |||
|
|
|||
| return ( | |||
| <span {...htmlProps} className={tagClasses}> | |||
| <span {...htmlProps} className={tagClasses} onClick={onClick}> | |||
| @@ -18,6 +18,22 @@ export interface ITagProps extends IProps, IIntentProps, React.HTMLAttributes<HT | |||
| */ | |||
| active?: boolean; | |||
|
|
|||
| /** | |||
| * Whether the tag should respond to user interactions. If set to `true`, | |||
address commentsPreview: documentation | landing | table |
add CSS API docsPreview: documentation | landing | table |
giladgray
reviewed
Mar 16, 2018
| @@ -63,6 +64,7 @@ Styleguide pt-tag | |||
|
|
|||
| .pt-large - Large | |||
| .pt-round - Rounded corners, ideal for badges | |||
| .pt-interactive - Hover and active effects | |||
There was a problem hiding this comment.
@llorca i added CSS example for minimal tags
giladgray
approved these changes
Mar 16, 2018
Update _tag.scssPreview: documentation | landing | table |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.